Take the 2-minute tour ×
Programmers Stack Exchange is a question and answer site for professional programmers interested in conceptual questions about software development. It's 100% free, no registration required.

Suppose you have a client that interfaces with a server which in turn invokes an external service to fulfill some of the client's requests. I'm designing the client and server and need to accommodate the limitations of the external service. I have these options:

  1. Encapsulate (as much as possible) all code dealing with the service's limitations inside the server application.
  2. Encapsulate (as much as possible) all code dealing with the service's limitations inside the client application.
  3. Design both the client and server applications around the external service's limitations.

I had chosen option #1 because the server application was 'closer' to the external service and I didn't want to have to redesign the client if and when the external service was improved. However, now I'm being asked to choose option #3 by the server-side team so we can deal with the external service limitations in the API instead of by handling exceptions. Is there a design pattern I can reference to convince them (or myself) that one option is preferred? (Separation of concerns looks promising, but I haven't convinced myself that it's sufficient because it could also argue for option #2)

share|improve this question

2 Answers 2

up vote 3 down vote accepted

#1 is clearly the correct solution.

The client should know nothing about the implementation details of the server. Adding knowledge of the server's internal topology (that it talks to an "external" service) violates the Single Responsibility Principle and Separation of Concerns and couples your client to the particular current internal implementation details of the server.

From the client's perspective, there is only one "external service": the server. Whatever the server does to compute its response for the client, it is "internal" to the server from the perspective of the client. That is, the client must treat the server is a black box. The client makes requests and gets responses according to whatever protocol is implemented between the two. It should know nothing at all about how the server creates those responses.

share|improve this answer

IMHO both options 1 and 3 will probably end up looking the same way in the end, unless the server application actually has business logic that can handle limitations of the external service. In other words, the limits of external web service will likely influence the server application interface with the client, so the end result MIGHT be the same.

On that note pursuing 1 is what SHOULD be done. The client in no way needs to directly communicate with the external web service, the only client for the external web service is the server application.

The scenario you describe is where most componentized software applications go awry and develop design smells. The server application team is refusing to acknowledge that business logic integrating with the external web service is their responsibility.

I have been in this situation before and a number of things cause this:

  • Server application team being ignorant of componentized software development.

  • Server application team is overworked and has a tight schedule, trying to push work back onto other teams

  • Selfish manager trying to weasel out of further responsibilities for himself and his/her team.

  • Server application team is just being lazy and wants to be a hollow middleman between the external web service and their client.

share|improve this answer
    
I (embarrassingly) had never heard of design/code smells. I looked it up and "Inappropriate intimacy" fits the situation perfectly, thanks! As for how #1 and #3 compare in implementation, there is a significant difference in this case because the service can handle only a single task at a time, but it's the same task it would be requested to multiple times concurrently. PS I think I'll avoid the temptation to select a motivation for the server team ;) –  Stephen Rudolph Oct 5 '11 at 17:45
    
Also, apparently I can only select one answer (and I don't have enough points to upvote anything yet), otherwise I'd select this answer too and upvote both –  Stephen Rudolph Oct 5 '11 at 17:47
    
@StephenRudolph I find that understanding the motivations and nature of other teams is important to negotiating, and even manipulating them to your needs. Deep down inside you know the answer, but I understand why you wouldn't want to share :) –  maple_shaft Oct 5 '11 at 18:59

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.