Take the 2-minute tour ×
Programmers Stack Exchange is a question and answer site for professional programmers interested in conceptual questions about software development. It's 100% free, no registration required.

I'm creating a website based on users' code, a place where they can share code in a social way and one of the features I'm currently developing is Code Review.

This feature will allow users to evaluate code in certain aspects, from the top of my head I came out with things like:

  • Legibility,
  • Performace and
  • Modularity.

What are the general characteristics that you evaluate when reviewing code?

share|improve this question

closed as too broad by MichaelT, Bart van Ingen Schenau, Martijn Pieters, gnat, GlenH7 Feb 24 at 14:48

There are either too many possible answers, or good answers would be too long for this format. Please add details to narrow the answer set or to isolate an issue that can be answered in a few paragraphs.If this question can be reworded to fit the rules in the help center, please edit the question.

1  
This is a pretty subjective area. Creative coders do not always like code metrics any more than they like being rated by HR department on the scale 1 to 5. –  Job Jan 18 '12 at 3:52
    
Yep, i know it. Metrics and values could be cold but users will be also having to say way, so this way i think everyone could learn something with it –  guiman Jan 18 '12 at 3:58
1  
@guiman To get a better feel how code reviews are done, you should consider joining Code Review Stack Exchange, although still in beta there are quite a few great reviews there. Check them out, and I'm pretty sure you'll get a very good idea how to evaluate code. –  Yannis Rizos Jan 18 '12 at 8:37
    
And also make sure you read this relevant question –  Yannis Rizos Jan 18 '12 at 8:44

2 Answers 2

You mention performance, will your website have the ability to measure this?

If so, I would think the most important thing to measure would be does it give the correct answer?

Next you could measure memory usage and speed as secondary goals.

share|improve this answer

AFAIK, most languages have some form of a lint program (i.e. jslint for Javascript, FlexPMD for Actionscript, pep8 and pylint for Python, etc.).

I would strongly suggest relying on standards set by the respective communities and using OS tools to parse code that you're hosting. If you were to couple this with peer reviews, you'd have yourself a pretty strong code review system. Linting is something that should be in any strong developer's pipeline, so I'd expect that most developers would like having this built into an automated system for them rather than having to build it into their pipelines (i.e. makefiles) themselves.

share|improve this answer
    
This is just great, really. I'll be considering building something to allow linting –  guiman Jan 18 '12 at 4:32

Not the answer you're looking for? Browse other questions tagged or ask your own question.