Take the 2-minute tour ×
Programmers Stack Exchange is a question and answer site for professional programmers interested in conceptual questions about software development. It's 100% free, no registration required.

I'm looking for a light-weight code review process. A couple of requirements, the reviewer must be able to do the review alone at the time of his/her choosing (not tied to check-ins), the reviewer must be able to easily find the target code, the review has to leave some document showing what was reviewed. I know there are tools available for code review but I work in a very ridig environment and introducing new tools is not an option.

One idea I've been thinking about is to create a new Visual Studio Task List token called REVIEW, and use it to mark the code that needs reviewing.

Something like,

// REVIEW doe_john: New method, not sure about the exception.

Then we would add a Review workitem in TFS (we're using the CMM template).

Another possibility, which I would actually prefer, would be to have developers create a TFS Review workitem and add links to code to it, but I don't know if this is possible. Obviously you can add a link to a file, but I'd like to have a link to a particular method.

share|improve this question

migrated from stackoverflow.com Aug 29 '12 at 14:14

This question came from our site for professional and enthusiast programmers.

    
There seems to be quite a few threads on code review on StackOverflow, so I'm not sure why this would be wrong. But I'll try StackExchange. –  Rubio Dec 15 '11 at 6:29
    
relevant for teams too programmers.stackexchange.com/questions/139321/… –  jk. Aug 29 '12 at 14:43
2  
I think it's a really bad idea to modify the code in order to say "please review this" as this means post-review the code must be edited and that allows for merge/cut-n-paste errors which may result in the checked-in code not not really resembling the pre-review code or not compiling. –  JBRWilkinson Aug 29 '12 at 14:48
add comment

2 Answers

I haven't tried it myself, but a number of my friends have recommended Crucible. I've always used a process where reviewers mark up the code and then meet to discuss what they found. It works well, but the meetings can be hard to schedule and it's easy to get bogged down in minutiae. Crucible seems to support the same sort of process, but without the need for the meeting.

share|improve this answer
    
crucible is nice, the only thing I miss compared with reviewing code in an IDE is a 'go to definition' button –  jk. Aug 29 '12 at 14:42
add comment

Here's some good info: Code Review

I liked:

  1. Explain context of the change I am reviewing.
  2. Show me your unit tests.
  3. Show me your code.
  4. Show me zero StyleCop warnings and zero FXCop violations.
  5. Show me all this building on the Continuous Integration server.

Very nice and lightweight.

(BTW odd that we share the same name...)

share|improve this answer
    
Just a handle I use. Got the nickname in Spain since I'm blond. ;) –  Rubio Oct 1 '12 at 20:11
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.