Take the 2-minute tour ×
Programmers Stack Exchange is a question and answer site for professional programmers interested in conceptual questions about software development. It's 100% free, no registration required.

I have done this static code analysis with Code Analyzer. Is it a green signal or should I improve my coding standards?

enter image description here

share|improve this question
    
You should state explicitly the language in use, and probably framework in order to assess that. From the tabs, I assume all Java. –  Orbling May 1 '11 at 5:27
    
You may want to post your code snippets to: codereview.stackexchange.com to have somebody review them for best practices. –  Paweł Dyda May 1 '11 at 7:56

2 Answers 2

up vote 2 down vote accepted

In short, that particular analysis you have run above isn't really telling you much. Comment ratios, white space ratios etc are pretty minor in the scheme of things.

Assuming you're in Javaland I'd take a look at FindBugs, Checkstyle, PMD etc. More importantly, try to get another peer to give it a quick review! Sure, static code analysis tools help you pick up lots of issues, but none of them can take the holistic look at the design/approach like a human can.

share|improve this answer

your analysis isn't a red light but it isn't a green light either.

I would say lengths and comment ratio's look fine. But that isn't enough.

You need to look at way more (cyclomatic complexity/dependencies/dead code etc etc)

Try Xdepend http://www.xdepend.com/ and show us or a peer reporting form that. Than you have a bit more insight but still that isn't the entire picture.

For the last gaps ask a peer he will be able to tell you if your code is readable, shows intent, if you have adhered to company policies/reused code already present in your company and stuff like that.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.