This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

1
vote
1answer
67 views

Java private method signature clarity and better practice [closed]

I received the code review comment for below code snippet - public void doWork(String a, Integer b) { .. .. SomeService service = getService(); for (Integer i : numbers) { ...
3
votes
2answers
106 views

Should static analysis be integrated with code review? [closed]

I want to integrate various static analysis tools, and then add the results as comments on a file within code review tools, such as Stash or Review board. I am exploring the feasibility of writing ...
10
votes
1answer
673 views

When making a fix to an earlier commit, should I rebase or add a separate fix up commit?

A common scenario in software development is code reviewing somebody else's code. A common tool for doing this is opening a Pull Request. My question is, when issues are found in the review, should ...
1
vote
4answers
127 views

What practical steps do you take to ensure you are thorough? [duplicate]

Bit of Context I'm not sure if this is fitting to the programmers.stackexchange area, but I'm not going to post it in SO. Any problem with ambiguity and I'll happily remove it. If I had to talk ...
1
vote
0answers
91 views

How to approach code review with limited resources

I've been given the following task: A company is giving source code for its product (comprising over 1 million lines of C++, Java, with some assembly) for my review. The code will be loaded ...
6
votes
5answers
815 views

What is the effectiveness of code reviewing by just reading? [duplicate]

I have been given the task of reviewing a change request comprising of more than 20 changes, the problem is that we do not / cannot install a version of the software to be evaluated as the development ...
27
votes
7answers
3k views

How to monitor code review efficiently?

I suspect major code review cover up in my team. Too many code reviews are merged without any comment. Seems to like there's no such thing as a code review without a single comment. How can I as ...
1
vote
2answers
229 views

Why is there only code review?

In my team I have applied a culture of code review and feature review. The code might look great, written spectacularly, however the feature might not work. It seems to me as 2 different scopes ...
2
votes
0answers
66 views

how to find typos and misspellings in code comments [closed]

I am getting familiar with some portion of code of a very large internal project (over 1 million lines of code) which is C-based and hosted on Mercurial repository. While looking at code, I found ...
53
votes
9answers
10k views

Bad sign if nobody can comprehend one's code? [duplicate]

If a coder writes code that nobody other than he can understand, and code reviews always end with the reviewer scratching his head or holding their head in their hands, is this a clear sign that the ...
4
votes
1answer
88 views

In 'branch by abstraction', how would one do code review?

My manager recommended I consider the technique of 'branching by abstraction', in which, rather than creating feature branches, multiple developers work in the same version control branch, and ...
5
votes
2answers
114 views

peer review code documentation [closed]

We all know that code reviews are generally a good practice, but what about reviewing documentation? Many devs that I work with will put up wiki pages, javadocs, etc, but most of the time, unless ...
3
votes
1answer
221 views

Been working on a project for the last 6+ months. Consultants have been brought in and want to change everything. What should I do? [closed]

Long story short, I have been the sole front end developer on this project since last summer. Consultants have been brought in to help accelerate our velocity. After one day and some knowledge ...
1
vote
1answer
60 views

How to avoid old commits/PRs that are painful to merge?

We have a pretty good code review process, but there are couple of issues. The most annoying problem is merging. From time to time the number of stuff to merge grows rapidly and some of the commits ...
1
vote
0answers
66 views

Reject pull request or accept incorrect code? [duplicate]

Very often I have to review pull requests of fellow programmers and I face the problem - what should I do when the code is not as good as I would expect? Should I reject the pull request or ...
-1
votes
1answer
93 views

How to get people to actually do code reviews promptly? [duplicate]

First things first, our company has decided to do code reviews. All of the engineers agree with (or accept) this. Code reviews are required as part of our development process for all commits. The ...
11
votes
1answer
389 views

Does pair programming remove the need of code reviews in an Extreme Programming (XP) project?

In an extreme programming project, programmers do pair programming most of the time. As these pairs also rotate, that is, you pair program with different people, and there is a sense of collective ...
3
votes
2answers
824 views

Do we still need manual code review if we use sonarqube code review tools

We were using git gerrit for manual code review . but recently we are planning to integrate sonarqube in our Jenkins integration server. Do we still need manual code review? Or we can stop manual ...
0
votes
1answer
100 views

How do I review code changes that are the result of syncing?

At my current job we develop code on a release branch and then do a code review. After all rework is done the final changes are also synced/merged to the 'main branch'. We want to be sure that all ...
1
vote
1answer
339 views

How to find duplicate strings

I allow my user to create profiles, meaning they potentially could create some with duplicate names. This can be problematic so I want to prevent them from doing so. I coded up this first pass ...
31
votes
10answers
3k views

How to deal with no code reviews in my new place when I come from that practice?

The team in my new company does not have a code review process. I come from companies with code review as a must culture and thus I don't feel comfortable committing my code without having it ...
4
votes
1answer
103 views

Pair programming via mailing list

I've started work on a large, open-source project recently. This project uses a mailing list for development, thus all patches must be mailed to this mailing list. This marks a change from my previous ...
3
votes
6answers
456 views

Explicitly define enum values, even if the default value is the same?

There are times when an enum's values are important: it is not necessary for them to be unique, they also need to have specific values. In such cases, should the values be explicitly defined, even if ...
1
vote
1answer
97 views

How to keep class parameters visible while using generic argument passing

After writing some classes where class initialization requires multiple options, instead of writing several parameters into constructors or setters, I started passing an associative array of ...
0
votes
1answer
135 views

How often to open pull requests [closed]

We are planning to use Git pull requests for code review in our company. Before we start I have a basic question: How often should I open a pull request? Is it best to open one for every little commit ...
0
votes
1answer
122 views

Where to audit a codebase for dangerous code use [closed]

Not sure Programmers Stack Exchange is the place to ask this question, but thought I'd give it a go. Our team had a near miss recently with a nasty error where a method call had been added to the ...
56
votes
4answers
5k views

What is the purpose of a Code Review

I am in the process of trying to sell my organisation on the value of code reviews. I have worked at several places where they were employed. I have seen them used to nitpick styling choices, and ...
2
votes
4answers
446 views

In Agile, should I create a code-review task?

My team uses Agile as a development approach. Currently, each task has four states which are todo, in progress, testing, and done. We've just started doing code reviews, and I wonder if I need to ...
-4
votes
1answer
175 views

Code review revenge [closed]

In the company where I work we are doing code reviews. I gave some negative comments about the code (code duplication) of programmer A. My commit was OK and ready to merge and then programmer A added ...
1
vote
3answers
643 views

Should we enforce code style in our large codebase? [duplicate]

By "code style" I mean 2 things: Style, eg. // bad if(foo){ ... } // good if (foo) { ... } Conventions and idiomaticity, where two ways of writing the same thing are functionally equivalent, but ...
3
votes
3answers
244 views

What is the appropriate amount of guidance and mentorship a junior programmer should receive? [closed]

I'm a junior software developer, and just got this job working with a very small group of engineers. I've been coding for a few months in this group in a professional settings - before I just coded at ...
13
votes
6answers
451 views

What is the best way for a programmer to handle being code reviewed?

I am fairly new to code review, but I have been coding for years during my PhD - which doesn't always make you a good programmer! If the reviewer changes your code and goes through it with you ...
4
votes
3answers
320 views

When to stop reviewing code?

I am working in a team of 4 members. we have started reviewing code 2 months ago. we are using Gerrit as code review tool. while reviewing code initially we have found lot's of problem in the code ...
1
vote
2answers
117 views

Apply filter only if not null

My function takes an optional parameter, type, which is used to filter through a collection. However, the filter should only apply if the parameter is passed in (in other words, non-null). If the ...
44
votes
12answers
3k views

Reconciling the Boy Scout Rule and Opportunistic Refactoring with code reviews

I am a great believer in the Boy Scout Rule: Always check a module in cleaner than when you checked it out." No matter who the original author was, what if we always made some effort, no ...
18
votes
3answers
2k views

Is it good to review programs with seniors and boss even if it is working fine?

In my company, before delivery of any project, my boss asks my seniors to review programs written by me or other team members or sometimes boss also sits with us for review. I think it is a good way ...
2
votes
5answers
305 views

Simplicity-efficiency tradeoff

The CTO called to inform me of a new project and in the process told me that my code is weird. He explained that my colleagues find it difficult to understand due to the overly complex, often new ...
3
votes
0answers
184 views

How can I make a universal construction more efficient?

A "universal construction" is a wrapper class for a sequential object that enables it to be linearized (a strong consistency condition for concurrent objects). For instance, here's an adapted ...
1
vote
3answers
204 views

Is it appropriate to remove redundant code explicitly assigning the default values?

Sometimes while I'm editing something I see some useless code added by other developers, probably due to habit. Editing this code will not make any difference, so is it appropriate? In my specific ...
2
votes
2answers
167 views

Checking program robustness using static code analysis

(Building on this question) If you have a static code analyser such as Checkstyle, is it possible to to relate any of the stuff that it checks for to actual robustness? Some of the things that ...
3
votes
3answers
210 views

What can I do to let our team have code reviews of branch merges having hundreds of screens worth of Github diffs?

"Code review" (aka "peer review") seems like a really great idea, so my team started practicing it. For a little while it worked well, but then a co-worker merged a branch in, and asked for a review ...
27
votes
10answers
4k views

Getting coders to do code review [duplicate]

I am running a project where I pay developers to contribute to my semi open source project. My problem is that it is easy to hire developers, but it is very difficult to get anyone to do code ...
2
votes
1answer
85 views

How to do an effective code review of library changes?

One of my projects just changed the version number of a supporting third-party library. Specifically, we changed a J2EE app from JPA 1.x to JPA 2.0. Our CI system has had this change for a week and ...
4
votes
1answer
287 views

If TDD is design, how do you know your TDD is well designed? [duplicate]

Given a large group (50+) of programmers: All given the same problem, All using Test-Driven Development (TDD), All pair programming, All doing group-based code review, I have personally seen the ...
1
vote
2answers
249 views

Is there any issue if ternary operator is used in super() method [closed]

I am using a ternary operator in super () method of my code. While the code went for review, I got a reply that Strictly don’t use ternary operators in the Super() calls. Is there any problem ...
4
votes
3answers
266 views

How do I effectively address code-review feedback about class and method names without a suggestion for a better or alternate name?

Part of code review feedback is suggesting better names for methods and classes. How can I address feedback about class and method names which does not suggest an alternative? For example, I might ...
10
votes
5answers
660 views

Who should do code reviews?

In my company mostly the architect does code reviews. He is a very experienced and smart software guy, so he is very good at it. When developers do the code reviews they don't do it half as well. We ...
3
votes
2answers
192 views

Is it normal to get your software development products critiqued?

I am currently a software developer on coop that was in an interesting situation today. I cannot say too much, as the things I do are under NDA, but I make Grasshopper 3D (which is a Rhino plugin) ...
2
votes
6answers
1k views

Should I use automatic properties?

I'm new to C# coming from a Java background. I'm working on a take home assignment for a coding interview. I normally write my code as following(Java): public class Test { //fields private ...
0
votes
3answers
4k views

Logic inside class properties setters & getters [duplicate]

Trying to build a case against this as we have a developer that likes to use class properties in place of methods. I think it's a bad idea. In some cases he is accessing the data layer inside the ...