This tag is for questions about the practice of code review and code walkthroughs.
6
votes
6answers
321 views
When conducting a code review, should the focus be on the completeness of the requirement?
Given that the reviewer is not part of the project, but was assigned to review because he has done some coding for the application being updated/enhanced.
Is it the reviewer's job to ensure that the ...
1
vote
0answers
117 views
Online Code Reviews [duplicate]
Possible Duplicate:
Website for code review
Where can I post my code online so people can comment, make suggestions, and/or criticism? I tried 4chan but people lose interest fast if you ...
2
votes
1answer
589 views
How Should I reply to my Manager about my annual review [closed]
During testing, our software testers reported a NullException error in an application and I was tasked to fix it. I did some investigation, proposed a fix, and sent out a code review to the team. I ...
7
votes
4answers
606 views
Website for code review
I know that we all are trying to improve our structure and style of our code, striving to be truly agile.
Websites like Stack Overflow are great when you want an answer to a specific question but ...
3
votes
4answers
743 views
source code check in / validation best practices
I am looking for best practices that big organizations follow for code check-in and validations.
Currently we follow these steps,
- Developer writes code
- Developer do some initial tests
- Code is ...
4
votes
2answers
221 views
Are there any private code review communities?
Similar to this question Code Review Services, are there any communities out there where I can get my code reviewed. Ideally this would be a private thing between you and the reviewer as it would be ...
6
votes
2answers
341 views
Tools and/or methods for regular Code review of Remote development team
We are outsourcing a development to a small team of offshore devlopers. Our in house process for code review is manual, paper based, based on a waterfall model requiring "big bang" delivery. It ...
12
votes
6answers
992 views
Why should I write all the Statements within Try-Catch?
My company head says that I must write all , i.e. ALL my code within Try-catch statements. Now, I can understand the 'better be safe than sorry' approach here, but isn't it too chicken-hearted to ...
2
votes
4answers
443 views
Should code reviewers test as part of the review? [duplicate]
Possible Duplicate:
trust factor in code review
Where I work, we have very few rules about what constitutes a code review. In addition to going through the code, I tend to briefly test out ...
6
votes
6answers
264 views
If your team does code review, to what extent do you verify that review fixes are carried out?
On my team, we carry out code reviews (without the use of external tools). The reviewer produces a list of items which the developer should address or consider and then essentially leave them to it ...
9
votes
5answers
519 views
How to facilitate code reviews in a small team for embedded software?
Short Question
Does a cost-effective tool / workflow exist to facilitate code reviews in a small team? More specifically, a small team that relies on post-commit code reviews.
Background
Our team ...
14
votes
10answers
1k views
Interview: Review another developer's code
One of my colleagues recently left and I've been asked to review the code of an interviewee coming in to replace him.
I have no idea what code he'll bring along with him and moreover have never been ...
34
votes
7answers
1k views
Working as a sole developer: getting code looked over
I have no choice but to work on my own, and can't find an adequate solution for getting my work looked over, sanity checked, having someone to brainstorm ideas with, discussing best practices and so ...
6
votes
5answers
596 views
trust factor in code review
How much should a reviewer trust the coder who submits the code for review?
I always have that dilemma of whether I should go test of the changes proposed or should I trust the submitter that he ...
1
vote
1answer
151 views
Multistream Project v/s Single Stream project
If we want to have code reviews before a developer delivers his work, then can you suggest whether multi stream project { i.e., each developer create his own stream and view and later deliver to ...
16
votes
7answers
452 views
Could an internal rep, voting and badges encourage good programming practices?
Just thinking out aloud - we programmers love all this voting/badges/rep stuff so could a scheme like this be introduced into a companies code review process to encourage better coding.
Something ...
10
votes
5answers
509 views
How to be better at reviewing code?
First I firmly believe in the code review process and always want someone else to review my code. My question really centers around how can I do a better job at performing a code review for someone ...
3
votes
1answer
142 views
Peer review for UI Development
I am the only front-end developer in a team composed for 3 .Net devs, 1 QA and 1 PM. Although we have another team from another office halfway around
the world, to whom would i do code review with?
...
9
votes
7answers
1k views
Code Reviews do they really work in true Agile?
So I started working for a large corp., one of those with 3 letters in the name, and they are trying to become Agile, but have tons of processes, which I don't feel are Agile.
The one that has me the ...
6
votes
1answer
146 views
Is Open Market Code Review a Good Idea?
I have a huge program that I have been developing for almost 2 years. It will probably go commercial in about 6-9 months, but seeing as it is just me developing it, I'd had almost zero feedback about ...
1
vote
4answers
316 views
How to avoid being overwhelmed when doing code review?
I'm pretty new to code review, and I feel often overwhelmed by incoming changes.
I mean when there are serious code changes, coming from several developers I tend to accept everything without ...
8
votes
6answers
763 views
Code review guidelines for CSS, JS and HTML
I have been asked to create guidelines for review CSS, JS and HTML. I know there are coding guidelines for JS but I don't know any about HTML and CSS. To review JS I will certainly follow those ...
7
votes
9answers
1k views
Code Reviews, what are the advantages? [closed]
In my team, we don't do formal code reviews. We tend to think that it's enough with pair programming and rotating pairs often.
Should we consider doing formal code reviews?
What would be the ...
2
votes
2answers
136 views
Code reviewing in the presence of strong type inference and basic editors
I’m curious to know how folks deal with comparative code reviews (version x against y of a file) in the presence of strong type inference, that is when ‘var’ (in C#) or ‘auto’ (in C++ 0x) is used in ...
6
votes
2answers
274 views
Where can I get the code I write on my own for practice evaluated?
I am a fresher. My job is not very demanding of me when it comes to exercising my programming prowess. So, I have started to write code on my own (a simple space invasion program, chat application, ...
19
votes
15answers
963 views
What's a good, concise way to explain the dangers of copy-paste programming to non-programmers?
I'm looking for a good analogy or metaphor that could illustrate the problems of copy-paste programming to non-programmers. I occasionally do code/system reviews for potential clients, and one of the ...
1
vote
1answer
139 views
Suggestions for finding code to review, that is for CodeReview.SE
Looking for suggestions on finding code to review, or to be more clear, code on SE sites with excepted working code -- to suggest be posted to CodeReview.SE for optimization.
The source of this ...
7
votes
1answer
1k views
Combining Code Review with Trust Metrics
I don't get the chance to partake of it at work. But I love the idea of code review.
Especially of online open source code review like Gerrit Code Review.
I love what Trust Metrics have done for ...
2
votes
1answer
449 views
Diff annotation tool
Among the 11 proven practices for more effective, efficient peer code review, diff annotation seems to be the one particularly well suited to tool assistance. The article is written by the architect ...
1
vote
2answers
115 views
Building a common syntax and scoping framework
Hello fellow programmers,
I was discussing a project the other day with a colleague of mine and I was curious to see what others had to say or if such a thing already existed.
Background
There are ...
14
votes
5answers
2k views
When to do Code Review
We have recently moved to a scrum process and are working on tasks and user stories inside of sprints. We would like to do code reviews frequently to make them less daunting. We are thinking that ...
7
votes
6answers
826 views
How to evaluate the quality of Rails code?
In a code review, what do you look for to assess a developer's expertise? Given an opportunity to look at a developer's work on a real-world project, what tell-tale signs are a tip-off to carelessness ...
2
votes
4answers
336 views
outsourcing code review/refactoring
I have a small project (3000 lines in Python) that I wrote myself; it has no known bugs and has some decent parts, but is largely a mess because of my lack of time. Unfortunately, I have to be the one ...
0
votes
7answers
407 views
How do programmers deal with Project Lead/Managers?
Project Managers/Technical Leads sometimes tend to be over enthusiastic when it comes to software.
But during code reviews if instead of functionality of the code the only complain one hears is about ...
6
votes
6answers
357 views
Need Help in Pointing to focus on the Key elements in Code Review Phase? [closed]
Please share your views on the code review process.
If someone gave a code snippet and asked you to review that code, then what are the major things you will focus on that code Review process?
For ...
6
votes
3answers
452 views
Why it is not recommended to have set-only property?
Today at work one of my colleague reviewed my code,
and suggested me to remove set-only property and use method insted.
As we both were busy with other stuffs, he told me to look at Property Design ...
19
votes
8answers
1k views
How should code reviews be Carried Out?
My previous question has to do with how to advance code reviews among the developers. Here I am interested in how a code review session should be carried out, so that both the reviewer and reviewed ...
15
votes
2answers
3k views
Recommended process for code reviews with mercurial
We typically used Perforce and SmartBear's Code Collaborator at Big Corp and now we're also going to be using Mercurial for certain projects.
Code Collaborator support Mercurial (we are using ...
12
votes
7answers
722 views
What will be the best practice for having 'reviewed' source code in a source control repository?
What will be the best way to manage reviewed source code in a source control repository?
Should the source code go through a review process before getting checked in, or should the code review happen ...
18
votes
9answers
1k views
What should come first: testing or code review?
I'm quite new to programming design patterns and life cycles and I was wondering, what should come first, code review or testing, regarding that those are done by separate people?
From the one side, ...
15
votes
4answers
652 views
Advancing Code Review and Unit Testing Practice
As a team lead managing a group of developers with no experience ( and see no need) in code review and unit testing, how can you advance code review and unit testing practice?
How are you going to ...
6
votes
5answers
480 views
Do you use to third party companies to review your company's code?
I am looking to get the following -
Basic code review to make sure they follow the guidelines imposed.
Security code analysis to make sure there are no loopholes.
No performance bottlenecks by doing ...
30
votes
7answers
962 views
At what point does “constructive” criticism of your code become unhelpful?
I recently started as a junior developer. As well as being one of the least experienced people on the team, I'm also a woman, which comes with all sorts of its own challenges working in a ...
3
votes
9answers
324 views
What tools do you use to let you know that methods in your codebase are getting too long? [closed]
Most people seem to agree that long methods are a code smell - a sign something may not be quite right with the code contained in them.
Which tools do you use to detect this smell?
clarified title ...
3
votes
5answers
504 views
How to price code reviews to encourage good behavior?
I work for a company that has a hosted .net internet application with many clients. Those clients often want to write customizations for our application. We have APIs to hook into the app, but the ...
5
votes
3answers
221 views
Is it common practice to hire third parties to do code reviews for contractors?
I recently observed some contract offers which included a "code review by third party" clause - the contract would not pay out fully until the code review was completed and it received a pass.
I was ...
12
votes
5answers
501 views
How to deal with someone who dislikes the idea of code reviews?
Obviously, if management buy into spending time with code reviews, then everyone has to do it.
But there are always those guys (or gals) who resist with every ounce of their being.
How do you ...
9
votes
4answers
1k views
What tools can be used to facilitate code reviews after commits?
I've been evaluating a number of code review tools (mostly free ones), but they all seem to be aimed at reviewing patches before they are committed. This wouldn't really fit within our workflow with ...
17
votes
5answers
758 views
What does a standard code review contain?
In my company, it's an email discussion of what feature is implemented and what kind of bug is fixed sent by the one who write the code. And the reviewer, who receives the mail, will review the code ...
16
votes
11answers
1k views
How to review code that you do not understand?
I have been given the role to improve development in our company. The first thing I wanted to start was code reviews since that has never been done here before.
There are 3 programmers in our ...
