This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

8
votes
6answers
2k views

How to evaluate code quality when you're not familiar with the language? [closed]

As a hypothetical, if I were to interview someone for a new PHP developer position when my experience is in .NET, how can I determine if the code sample they've provided me is efficient and of good ...
8
votes
5answers
654 views

What's the best way to comment in a code review?

My team just started using crucible/fisheye for initiating code reviews whenever one of us checks something in. There are only 3 of us, and we're each encouraged to review the code and leave comments ...
8
votes
9answers
1k views

How can I promote clean coding at my workplace?

I work with a lot of legacy Java and RPG code on an internal company application. As you might expect, a lot of the code is written in many different styles, and often is difficult to read because of ...
8
votes
9answers
2k views

What is the way to understand someone else's giant uncommented spaghetti code? [duplicate]

Possible Duplicate: I’ve inherited 200K lines of spaghetti code — what now? I have been recently handled a giant multithreaded program with no comments and have been asked to understand what ...
8
votes
4answers
603 views

How can you get constructive criticism for your code?

My team rarely does code review, mainly because we don't have enough time and people lack the energy and will to do so. But I would really like to know what people think about my code when they read ...
8
votes
2answers
712 views

Tools and/or methods for regular Code review of Remote development team

We are outsourcing a development to a small team of offshore developers. Our in house process for code review is manual, paper based, based on a waterfall model requiring "big bang" delivery. It ...
8
votes
2answers
7k views

How to determine the effectiveness of a code review process?

We've introduced a code review process within our organisation and it seems to be working well. However, I would like to be able to measure the effectiveness of the process over time, i.e. are we not ...
8
votes
4answers
651 views

What are benefit/drawbacks of classifying defects during a peer code review

About 3 months ago, our engineering group rolled out Review Board to be used for all peer code reviews. Today, I had a discussion with one of the people involved in that process and found out that we ...
7
votes
2answers
535 views

Are there any opensource APIs that help analyze code?

As an example, let's say that I need to check for a certain usage of C# code and warn the user that that is a bad pratice. There are multiple usages that I want to detect, such as: Resource not ...
7
votes
2answers
299 views

Where can I get the code I write on my own for practice evaluated?

I am a fresher. My job is not very demanding of me when it comes to exercising my programming prowess. So, I have started to write code on my own (a simple space invasion program, chat application, ...
7
votes
3answers
680 views

Why it is not recommended to have set-only property?

Today at work one of my colleague reviewed my code, and suggested me to remove set-only property and use method insted. As we both were busy with other stuffs, he told me to look at Property Design ...
7
votes
4answers
638 views

How should I implement code review in this situation?

My question is about how to put code review into practice in a workplace where nobody else has asked for it, I've never done it before, and I'm not entirely sure if it's worthwhile for this type of ...
7
votes
3answers
546 views

Does studying other people's programs help in self growth? [closed]

Should I be studying big softwares written by other people in our company? My work may be a small sub module on the top of that software, and I may not be required to know what goes beneath the hood, ...
7
votes
8answers
398 views

If your team does code review, to what extent do you verify that review fixes are carried out? [closed]

On my team, we carry out code reviews (without the use of external tools). The reviewer produces a list of items which the developer should address or consider and then essentially leave them to it (...
7
votes
7answers
1k views

How to get developers to do code reviews in a timely manner

The company I work for requires all code to be reviewed by other developers before it is committed. The members of my team are often frustrated because the other developers are too busy coding to do ...
7
votes
3answers
439 views

amount of code in code review

In my experience, most teams in the company review the code of team member with a small amount of code, always less than hundreds of lines. Is it appropriate to review large amount of code, for ...
7
votes
6answers
639 views

what is the best way to ensure accountability in code checkins?

Note: after writing this I realize that this question is perhaps philosophical, but I'm interested in how the industry handles this scenario regardless. I have recently been working with a code base ...
7
votes
1answer
184 views

Tool to identify potential reviewers for a proposed change

Is there a tool that takes as input a proposed patch and a git repository, and identifies the developers are the best candidates for reviewing the patch? It would use the git history to identify the ...
7
votes
5answers
2k views

How to evaluate the quality of Rails code?

In a code review, what do you look for to assess a developer's expertise? Given an opportunity to look at a developer's work on a real-world project, what tell-tale signs are a tip-off to carelessness ...
7
votes
3answers
485 views

Is it common practice to hire third parties to do code reviews for contractors?

I recently observed some contract offers which included a "code review by third party" clause - the contract would not pay out fully until the code review was completed and it received a pass. I was ...
7
votes
2answers
2k views

Gerrit, git and reviewing whole branch

I'm now learning Gerrit (which is the first code review tool I use). Gerrit requires a reviewed change to consist of a single commit. My feature branch has about 10 commits. The gerrit-prefered way ...
7
votes
1answer
165 views

Is Open Market Code Review a Good Idea?

I have a huge program that I have been developing for almost 2 years. It will probably go commercial in about 6-9 months, but seeing as it is just me developing it, I'd had almost zero feedback about ...
7
votes
1answer
1k views

Combining Code Review with Trust Metrics

I don't get the chance to partake of it at work. But I love the idea of code review. Especially of online open source code review like Gerrit Code Review. I love what Trust Metrics have done for ...
6
votes
5answers
844 views

What is the effectiveness of code reviewing by just reading? [duplicate]

I have been given the task of reviewing a change request comprising of more than 20 changes, the problem is that we do not / cannot install a version of the software to be evaluated as the development ...
6
votes
9answers
980 views

Review quality of code [duplicate]

I have been asked to quality review two code bases. I've never done anything like that, and need advice on how to perform it and report it. Background There are two providers of code, one in VB and ...
6
votes
6answers
404 views

Need Help in Pointing to focus on the Key elements in Code Review Phase? [closed]

Please share your views on the code review process. If someone gave a code snippet and asked you to review that code, then what are the major things you will focus on that code Review process? For ...
6
votes
6answers
707 views

When conducting a code review, should the focus be on the completeness of the requirement?

Given that the reviewer is not part of the project, but was assigned to review because he has done some coding for the application being updated/enhanced. Is it the reviewer's job to ensure that the ...
6
votes
6answers
859 views

trust factor in code review

How much should a reviewer trust the coder who submits the code for review? I always have that dilemma of whether I should go test of the changes proposed or should I trust the submitter that he ...
6
votes
5answers
438 views

How to promote code review as an employee? [closed]

I have just graduated not long ago and started to work in a startup company for almost a year. I have introduced git to my current company and they are now happy to use it for version control. I feel ...
6
votes
3answers
292 views

What quality level in the commit history can/should I expect/enforce?

I worked as a lone developer for a long time. During this time, I developed a way of formulating and ordering commit messages: Refactor first, describe exactly the reason for the commit in the message,...
6
votes
4answers
491 views

How do you deal with discovering bad and false code in your team? [duplicate]

Every year in january we process a big task with our system. While the performance during the task was above average the maintaince follow up is currently having a lot of trouble with jobs running too ...
6
votes
2answers
1k views

Should a code review be different for front-end web developers?

Web developers code in a minimum of four languages (HTML, CSS, JavaScript, and a server-side language), must produce a working result in several different browser implementations, and may work on the ...
6
votes
2answers
567 views

Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes?

Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes? Is it simply too hard to do? I find this to be a major hole of most programmer's toolkits. From ...
6
votes
2answers
140 views

peer review code documentation [closed]

We all know that code reviews are generally a good practice, but what about reviewing documentation? Many devs that I work with will put up wiki pages, javadocs, etc, but most of the time, unless ...
6
votes
3answers
293 views

Branches/decision count in an example

Having read SO, just found this question: if (x > y) print (x) else if (x < y) print (y) else print (x,y) How many branches and decisions are there? It mentiones there should ...
5
votes
2answers
3k views

Do we still need manual code review if we use sonarqube code review tools

We were using git gerrit for manual code review . but recently we are planning to integrate sonarqube in our Jenkins integration server. Do we still need manual code review? Or we can stop manual ...
5
votes
7answers
2k views

How to avoid typo errors, etc?

For the first time I have been coding for an open-source software where all my work gets reviewed before being commited. I understand reviewing work isn't an easy task, so I don't like to waste ...
5
votes
1answer
348 views

Word for red flags / warning signs?

When reading about best practices and code reviews, I have come across a word/phrase that people on forums have used to describe code that should be a warning sign that the programmer may have missed ...
5
votes
2answers
13k views

Code review process when using GIT as a repository?

What is the best process for code review when using GIT? We have an external GIT provider (Unfuddle) and have caps on resource usage - so we can't have dedicated remote repositories for every dev. ...
5
votes
1answer
1k views

Code review approaches [closed]

Just going out on a limb here. Is doing a code review by sampling a few classes and units of code by a developer good enough to judge what he has done wrong to provide inputs? This is just in case you ...
5
votes
2answers
157 views

Should static analysis be integrated with code review? [closed]

I want to integrate various static analysis tools, and then add the results as comments on a file within code review tools, such as Stash or Review board. I am exploring the feasibility of writing ...
5
votes
1answer
228 views

How to perform code review of visual code?

Lately, I've been writing code in SAS Enterprise Guide, which produces "code" that looks like this (screenshot from the linked page): My question is twofold: Do you think it's necessary to ...
5
votes
2answers
247 views

CI tests to enforce specific development rules - good practice?

The following is all purely hypothetical and any particular portion of it may or may not accurately describe real persons or situations, whether living, dead or just pretending. Let's say I'm a ...
5
votes
2answers
156 views

Are formal inspections used in practice today?

I was thinking, we are taught to perform code reviews, inspections etc. but in reality, does anyone really do formal (Fagan) inspections? I cannot find anything on the topic.
5
votes
1answer
499 views

How is the Linux repository administrated?

I am amazed by the Linux project and I would like to learn how they administrate the code, given the huge number of developers. I found the Linux repository on GitHub, but I do not understand how it ...
5
votes
1answer
598 views

What would Business Intelligence (BI) developers look for in code reviews?

Let me preface this with saying I am not a Business Intelligence (BI) developer. I'm a .NET developer, and I have only a vague notion of what BI is, and encompasses. I've been an evangelist for a ...
5
votes
0answers
316 views

How can I make a universal construction more efficient?

A "universal construction" is a wrapper class for a sequential object that enables it to be linearized (a strong consistency condition for concurrent objects). For instance, here's an adapted wait-...
4
votes
3answers
355 views

When to stop reviewing code?

I am working in a team of 4 members. we have started reviewing code 2 months ago. we are using Gerrit as code review tool. while reviewing code initially we have found lot's of problem in the code i.e....
4
votes
5answers
230 views

Review tests first

I am going to adopt TDD in our team and one of the ideas I have is to review tests first. So one would write interfaces, mocks, and tests first, submit them for a code review and once interfaces and ...
4
votes
3answers
728 views

Code review if nobody in team has knowledge in some technology?

Sample situation: A team of Java developers starts an iOS project. Only one developer has Objective-C/iOS knowledge, and in the beginning he will work on this project alone. How we can perform code ...