This tag is for questions about the practice of code review and code walkthroughs.
6
votes
2answers
1k views
How to determine the effectiveness of a code review process?
We've introduced a code review process within our organisation and it seems to be working well. However, I would like to be able to measure the effectiveness of the process over time, i.e. are we not ...
6
votes
1answer
146 views
Is Open Market Code Review a Good Idea?
I have a huge program that I have been developing for almost 2 years. It will probably go commercial in about 6-9 months, but seeing as it is just me developing it, I'd had almost zero feedback about ...
5
votes
7answers
617 views
How to avoid typo errors, etc?
For the first time I have been coding for an open-source software where all my work gets reviewed before being commited. I understand reviewing work isn't an easy task, so I don't like to waste ...
5
votes
1answer
313 views
Word for red flags / warning signs?
When reading about best practices and code reviews, I have come across a word/phrase that people on forums have used to describe code that should be a warning sign that the programmer may have missed ...
5
votes
7answers
639 views
How to get developers to do code reviews in a timely manner
The company I work for requires all code to be reviewed by other developers before it is committed. The members of my team are often frustrated because the other developers are too busy coding to do ...
5
votes
1answer
522 views
Code review approaches
Just going out on a limb here. Is doing a code review by sampling a few classes and units of code by a developer good enough to judge what he has done wrong to provide inputs? This is just in case you ...
5
votes
2answers
293 views
Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes?
Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes? Is it simply too hard to do?
I find this to be a major hole of most programmer's toolkits. From ...
5
votes
2answers
141 views
CI tests to enforce specific development rules - good practice?
The following is all purely hypothetical and any particular portion of it may or may not accurately describe real persons or situations, whether living, dead or just pretending.
Let's say I'm a ...
5
votes
4answers
7k views
SVN code review tool
I would like to do some code review on the SVN repository used by our team.
For now, I've used Eclipse: show log on trunk, click on a revision and "Compare" to see the changes. The diff renders ...
5
votes
3answers
219 views
Is it common practice to hire third parties to do code reviews for contractors?
I recently observed some contract offers which included a "code review by third party" clause - the contract would not pay out fully until the code review was completed and it received a pass.
I was ...
5
votes
1answer
261 views
What would Business Intelligence (BI) developers look for in code reviews?
Let me preface this with saying I am not a Business Intelligence (BI) developer. I'm a .NET developer, and I have only a vague notion of what BI is, and encompasses.
I've been an evangelist for a ...
4
votes
5answers
211 views
Review tests first
I am going to adopt TDD in our team and one of the ideas I have is to review tests first. So one would write interfaces, mocks, and tests first, submit them for a code review and once interfaces and ...
4
votes
8answers
605 views
How can I promote clean coding at my workplace?
I work with a lot of legacy Java and RPG code on an internal company application. As you might expect, a lot of the code is written in many different styles, and often is difficult to read because of ...
4
votes
3answers
198 views
What quality level in the commit history can/should I expect/enforce?
I worked as a lone developer for a long time. During this time, I developed a way of formulating and ordering commit messages: Refactor first, describe exactly the reason for the commit in the ...
4
votes
1answer
210 views
How to perform code review of visual code?
Lately, I've been writing code in SAS Enterprise Guide, which produces "code" that looks like this (screenshot from the linked page):
My question is twofold:
Do you think it's necessary to ...
4
votes
4answers
759 views
Difference between static testing and code review [duplicate]
Possible Duplicate:
What is the difference between Static code analysis and code review?
What is the difference between static testing and code review?
I found some information on ...
4
votes
2answers
221 views
Are there any private code review communities?
Similar to this question Code Review Services, are there any communities out there where I can get my code reviewed. Ideally this would be a private thing between you and the reviewer as it would be ...
4
votes
2answers
310 views
code review with git-flow and github
With regular git and github I can do a code review by simply creating a pull request of the feature branch I'm working on to the master branch. How would I do code reviews with git-flow? With workflow ...
4
votes
1answer
104 views
Rapid code analysis
I have recently moved to a new company where I am tasked (in part) with evaluating the existing code base and coming up with patterns and best practices.
Our development team consists of around 20 ...
4
votes
2answers
237 views
Can a Code Review help in learning the code-flow and/or technology of a large code-base?
I'm new to VC++, and so am not very familiar with COM, ActiveX, IDL etc. When I mentioned this to my tech-lead, he assigned me the task of doing the code review of files he felt were important, in ...
4
votes
1answer
495 views
Picking a code review tool [closed]
We are a startup looking to migrate from Fogbugz/Kiln to a new issue tracker/code review system. We are very happy with Jira, especially the configurability, but we are undecided on a code review ...
4
votes
2answers
106 views
Project organization with professionals and students
I am working as a PhD student developing scientific/engineering simulations and algorithms to be tested in these simulations. These days the first student started to work on my project (for his ...
3
votes
9answers
324 views
What tools do you use to let you know that methods in your codebase are getting too long? [closed]
Most people seem to agree that long methods are a code smell - a sign something may not be quite right with the code contained in them.
Which tools do you use to detect this smell?
clarified title ...
3
votes
7answers
324 views
What's the deal with code reviews? [closed]
I've been wondering about code reviews recently, based on how many questions I've seen on here talking about them.
Between my internships, contracts, and full time jobs, I've worked for six different ...
3
votes
5answers
502 views
How to price code reviews to encourage good behavior?
I work for a company that has a hosted .net internet application with many clients. Those clients often want to write customizations for our application. We have APIs to hook into the app, but the ...
3
votes
3answers
279 views
Python - Service, how to get a code review
I am usually a PHP and Delphi developer and have been getting into Python lately.
I am developing an app and would love to get some feedback on the code, there are few things which I would love to ...
3
votes
1answer
166 views
How can I make being code reviewed by someone who doesn't know the language easier?
I'm in a team where I am the only Java developer. The rest of the team are VERY experienced in their own programming language, but their area of expertise is not object orientated.
I found the first ...
3
votes
4answers
416 views
Reusable VS clean code - where's the balance?
Let's say I have a data model for a blog posts and have two use-cases of that model - getting all blogposts and getting only blogposts which were written by specific author.
There are basically two ...
3
votes
2answers
201 views
As a solo programmer, of what use can Gerrit be?
Disclaimer: I'm aware of the questions How do I review my own code? and What advantages do continuous integration tools offer on a solo project?. I do feel that this question aims at a different set ...
3
votes
4answers
740 views
source code check in / validation best practices
I am looking for best practices that big organizations follow for code check-in and validations.
Currently we follow these steps,
- Developer writes code
- Developer do some initial tests
- Code is ...
3
votes
1answer
142 views
Peer review for UI Development
I am the only front-end developer in a team composed for 3 .Net devs, 1 QA and 1 PM. Although we have another team from another office halfway around
the world, to whom would i do code review with?
...
3
votes
2answers
2k views
How to organize code review process
I'm looking for a light-weight code review process. A couple of requirements, the reviewer must be able to do the review alone at the time of his/her choosing (not tied to check-ins), the reviewer ...
2
votes
4answers
335 views
outsourcing code review/refactoring
I have a small project (3000 lines in Python) that I wrote myself; it has no known bugs and has some decent parts, but is largely a mess because of my lack of time. Unfortunately, I have to be the one ...
2
votes
4answers
292 views
Can notes/to-dos in code comments sent to code-reviews result in an effective refactoring process?
I want to start/improve a culture of collective code ownership at my company but at a geographically distributed level... I'd say there is some current collective code-ownership mentality, but only at ...
2
votes
4answers
251 views
How one could use a live editor
I was thinking about a live editing environment where code / a source file is synchronized so that changes made by one user would be carried across to all others editing the file.
Something like ...
2
votes
2answers
527 views
Can testers peer review the developers' design and code?
I am a junior developer for a small business using scrum / agile development. A long-term goal of ours is to be appraised at CMMI lvl 2. We have a team of 3 senior developers who implement user ...
2
votes
5answers
195 views
Who is responsible for fixing failed SQL code reviews? [closed]
As a DBA, most SQL is submitted to my team for review. We do not have a SQL developer, so the code is frequently very, very inefficient.
Our current process is:
SQL is submitted for review right ...
2
votes
1answer
344 views
How does your team approach technical code QA?
For the first time, our team is taking a rigorous approach to technical code QA. We identify work to QA by picking out top level classes and QA'ing it and everything it calls or uses below it (and ...
2
votes
2answers
306 views
Code review process when using GIT as a repository?
What is the best process for code review when using GIT? We have an external GIT provider (Unfuddle) and have caps on resource usage - so we can't have dedicated remote repositories for every dev.
...
2
votes
1answer
589 views
How Should I reply to my Manager about my annual review [closed]
During testing, our software testers reported a NullException error in an application and I was tasked to fix it. I did some investigation, proposed a fix, and sent out a code review to the team. I ...
2
votes
3answers
288 views
What feedback is or is not appropriate for a code review? [duplicate]
I am interested in hearing some guidelines as to what feedback is or is not appropriate for a code review. My team has a very unstructured review process and I am trying to suggest some ways to ...
2
votes
2answers
231 views
Why does the code auditing tools like FindBugs require a compile step to work properly?
Basically I ran Intellij Idea 's plug in called FindBugs-Idea to analyze my code . I corrected whatever errror was caught and then ran the tool again but it was still complaining about the same error ...
2
votes
3answers
741 views
Any Code Review tool with direct connection to CVS?
I've found many Code Review tools:
Phabricator (by Facebook) - http://phabricator.org/
Rietveld (by Google) - http://code.google.com/appengine/articles/rietveld.html
GitHub - https://github.com/
...
2
votes
4answers
443 views
Should code reviewers test as part of the review? [duplicate]
Possible Duplicate:
trust factor in code review
Where I work, we have very few rules about what constitutes a code review. In addition to going through the code, I tend to briefly test out ...
2
votes
2answers
472 views
How to document and peer review design in scrum?
I am a relatively new developer in a small business (a team of 3 developers and an equally small QA branch) working on a medium-sized system. The current iteration is still under 100k lines of code ...
2
votes
1answer
375 views
Gerrit, git and reviewing whole branch
I'm now learning Gerrit (which is the first code review tool I use). Gerrit requires a reviewed change to consist of a single commit. My feature branch has about 10 commits.
The gerrit-prefered way ...
2
votes
2answers
136 views
Code reviewing in the presence of strong type inference and basic editors
I’m curious to know how folks deal with comparative code reviews (version x against y of a file) in the presence of strong type inference, that is when ‘var’ (in C#) or ‘auto’ (in C++ 0x) is used in ...
2
votes
1answer
449 views
Diff annotation tool
Among the 11 proven practices for more effective, efficient peer code review, diff annotation seems to be the one particularly well suited to tool assistance. The article is written by the architect ...
2
votes
2answers
215 views
Code Review process
I'm looking for a light-weight code review process. A couple of requirements, the reviewer must be able to do the review alone at the time of his/her choosing (not tied to check-ins), the reviewer ...
2
votes
0answers
69 views
Checklist for coding MVVM web application
We are a small team working on a web application using MVVM design pattern using technologies like .NET, Knockout and HTML. I am trying to come up with a code review checklist for this, so that my ...
