This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

9
votes
5answers
1k views

Should code review be performed before or after unit tests

I am debating with my colleague on when to perform code review - before or after unit tests. What is the best practice? Some factors we might need to take into account (there may be more): Size ...
2
votes
4answers
276 views

How one could use a live editor

I was thinking about a live editing environment where code / a source file is synchronized so that changes made by one user would be carried across to all others editing the file. Something like ...
9
votes
3answers
2k views

Being prepared for a code review as a developer?

I am looking for some ideas here. I read the article How should code reviews be Carried Out and Code Reviews, what are the advantages? which were very informative but I still need more clarity on the ...
-2
votes
2answers
136 views

Better control on code updates

I will briefly explain my situation. I have a website in PHP, this website is powered by a custom framework + some "plug-in" made ad hoc for it. I am the only developer of this. Until now I just ...
51
votes
12answers
2k views

Releasing an open source project without getting embarrassed

I've been working by myself on a fairly large open source project for quite a while and it's nearing the point where I'd like to release it. However, I'm self-taught and I don't really know anyone who ...
23
votes
10answers
5k views

When to do code reviews when doing continuous integration?

We are trying to switch to a continuous integration environment but are not sure when to do code reviews. From what I've read of continuous integration, we should be attempting to check in code as ...
3
votes
4answers
5k views

How can I display a diff result in a single file or document? [closed]

I'm reviewing my peer's code. I use SourceGear DiffMerge as my diff program, on a Windows environment. While I'm using the diff program, I can clearly see the code changes, etc. Is it possible to ...
4
votes
2answers
355 views

Can a Code Review help in learning the code-flow and/or technology of a large code-base? [closed]

I'm new to VC++, and so am not very familiar with COM, ActiveX, IDL etc. When I mentioned this to my tech-lead, he assigned me the task of doing the code review of files he felt were important, in ...
89
votes
16answers
7k views

How can I tactfully suggest improvements to others' badly designed code during review?

I'm a great believer in clean code and code craftsmanship, though I'm currently at a job where this isn't regarded as a top priority. I sometimes find myself in a situation where a peer's code is ...
19
votes
4answers
812 views

How should I go about fixing code from a less-experienced programmer?

A little background: I am one of two programmers for our department of 10 people (the rest are artists and management). The two of us do all of the coding required to make things flow well, and ...
16
votes
12answers
2k views

Should we attempt to review all our code?

We're currently modifying out development process and I'm wandering if we should try to keep a 100% of our commits peer reviewed. What is your experience regarding code reviews? Do you tend to ...
6
votes
2answers
505 views

Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes?

Why don't many code review tools seem to be syntax aware or provide more in-depth analysis of changes? Is it simply too hard to do? I find this to be a major hole of most programmer's toolkits. From ...
6
votes
6answers
584 views

When conducting a code review, should the focus be on the completeness of the requirement?

Given that the reviewer is not part of the project, but was assigned to review because he has done some coding for the application being updated/enhanced. Is it the reviewer's job to ensure that the ...
1
vote
0answers
121 views

Online Code Reviews [duplicate]

Possible Duplicate: Website for code review Where can I post my code online so people can comment, make suggestions, and/or criticism? I tried 4chan but people lose interest fast if you ...
7
votes
0answers
683 views

Website for code review [duplicate]

I know that we all are trying to improve our structure and style of our code, striving to be truly agile. Websites like Stack Overflow are great when you want an answer to a specific question but ...
3
votes
4answers
1k views

source code check in / validation best practices

I am looking for best practices that big organizations follow for code check-in and validations. Currently we follow these steps, - Developer writes code - Developer do some initial tests - Code is ...
3
votes
2answers
254 views

Are there any private code review communities?

Similar to this question Code Review Services, are there any communities out there where I can get my code reviewed. Ideally this would be a private thing between you and the reviewer as it would be ...
7
votes
2answers
593 views

Tools and/or methods for regular Code review of Remote development team

We are outsourcing a development to a small team of offshore developers. Our in house process for code review is manual, paper based, based on a waterfall model requiring "big bang" delivery. It ...
12
votes
6answers
1k views

Why should I write all the Statements within Try-Catch?

My company head says that I must write all , i.e. ALL my code within Try-catch statements. Now, I can understand the 'better be safe than sorry' approach here, but isn't it too chicken-hearted to ...
3
votes
4answers
590 views

Should code reviewers test as part of the review? [duplicate]

Possible Duplicate: trust factor in code review Where I work, we have very few rules about what constitutes a code review. In addition to going through the code, I tend to briefly test out ...
7
votes
8answers
369 views

If your team does code review, to what extent do you verify that review fixes are carried out? [closed]

On my team, we carry out code reviews (without the use of external tools). The reviewer produces a list of items which the developer should address or consider and then essentially leave them to it ...
9
votes
3answers
940 views

How to facilitate code reviews in a small team for embedded software? [closed]

Short Question Does a cost-effective tool / workflow exist to facilitate code reviews in a small team? More specifically, a small team that relies on post-commit code reviews. Background Our team ...
14
votes
10answers
2k views

Interview: Review another developer's code [closed]

One of my colleagues recently left and I've been asked to review the code of an interviewee coming in to replace him. I have no idea what code he'll bring along with him and moreover have never been ...
35
votes
7answers
1k views

Working as a sole developer: getting code looked over

I have no choice but to work on my own, and can't find an adequate solution for getting my work looked over, sanity checked, having someone to brainstorm ideas with, discussing best practices and so ...
5
votes
5answers
702 views

trust factor in code review

How much should a reviewer trust the coder who submits the code for review? I always have that dilemma of whether I should go test of the changes proposed or should I trust the submitter that he ...
1
vote
1answer
230 views

Multistream Project v/s Single Stream project

If we want to have code reviews before a developer delivers his work, then can you suggest whether multi stream project { i.e., each developer create his own stream and view and later deliver to ...
17
votes
7answers
474 views

Could an internal rep, voting and badges encourage good programming practices?

Just thinking out aloud - we programmers love all this voting/badges/rep stuff so could a scheme like this be introduced into a companies code review process to encourage better coding. Something ...
10
votes
5answers
693 views

How to be better at reviewing code?

First I firmly believe in the code review process and always want someone else to review my code. My question really centers around how can I do a better job at performing a code review for someone ...
3
votes
1answer
221 views

Peer review for UI Development

I am the only front-end developer in a team composed for 3 .Net devs, 1 QA and 1 PM. Although we have another team from another office halfway around the world, to whom would i do code review with? ...
12
votes
7answers
4k views

Code Reviews do they really work in true Agile?

So I started working for a large corp., one of those with 3 letters in the name, and they are trying to become Agile, but have tons of processes, which I don't feel are Agile. The one that has me the ...
7
votes
1answer
160 views

Is Open Market Code Review a Good Idea?

I have a huge program that I have been developing for almost 2 years. It will probably go commercial in about 6-9 months, but seeing as it is just me developing it, I'd had almost zero feedback about ...
1
vote
4answers
424 views

How to avoid being overwhelmed when doing code review?

I'm pretty new to code review, and I feel often overwhelmed by incoming changes. I mean when there are serious code changes, coming from several developers I tend to accept everything without ...
9
votes
6answers
3k views

Code review guidelines for CSS, JS and HTML

I have been asked to create guidelines for review CSS, JS and HTML. I know there are coding guidelines for JS but I don't know any about HTML and CSS. To review JS I will certainly follow those ...
10
votes
9answers
4k views

Code Reviews, what are the advantages? [closed]

In my team, we don't do formal code reviews. We tend to think that it's enough with pair programming and rotating pairs often. Should we consider doing formal code reviews? What would be the ...
2
votes
2answers
149 views

Code reviewing in the presence of strong type inference and basic editors

I’m curious to know how folks deal with comparative code reviews (version x against y of a file) in the presence of strong type inference, that is when ‘var’ (in C#) or ‘auto’ (in C++ 0x) is used in ...
6
votes
2answers
292 views

Where can I get the code I write on my own for practice evaluated?

I am a fresher. My job is not very demanding of me when it comes to exercising my programming prowess. So, I have started to write code on my own (a simple space invasion program, chat application, ...
26
votes
17answers
2k views

What's a good, concise way to explain the dangers of copy-paste programming to non-programmers? [closed]

I'm looking for a good analogy or metaphor that could illustrate the problems of copy-paste programming to non-programmers. I occasionally do code/system reviews for potential clients, and one of the ...
1
vote
1answer
159 views

Suggestions for finding code to review, that is for CodeReview.SE

Looking for suggestions on finding code to review, or to be more clear, code on SE sites with excepted working code -- to suggest be posted to CodeReview.SE for optimization. The source of this ...
7
votes
1answer
1k views

Combining Code Review with Trust Metrics

I don't get the chance to partake of it at work. But I love the idea of code review. Especially of online open source code review like Gerrit Code Review. I love what Trust Metrics have done for ...
0
votes
1answer
848 views

Diff annotation tool [closed]

Among the 11 proven practices for more effective, efficient peer code review, diff annotation seems to be the one particularly well suited to tool assistance. The article is written by the architect ...
2
votes
2answers
175 views

Building a common syntax and scoping framework

Hello fellow programmers, I was discussing a project the other day with a colleague of mine and I was curious to see what others had to say or if such a thing already existed. Background There are ...
15
votes
5answers
3k views

When to do Code Review

We have recently moved to a scrum process and are working on tasks and user stories inside of sprints. We would like to do code reviews frequently to make them less daunting. We are thinking that ...
7
votes
5answers
1k views

How to evaluate the quality of Rails code?

In a code review, what do you look for to assess a developer's expertise? Given an opportunity to look at a developer's work on a real-world project, what tell-tale signs are a tip-off to carelessness ...
2
votes
4answers
618 views

outsourcing code review/refactoring [closed]

I have a small project (3000 lines in Python) that I wrote myself; it has no known bugs and has some decent parts, but is largely a mess because of my lack of time. Unfortunately, I have to be the one ...
0
votes
7answers
446 views

How do programmers deal with Project Lead/Managers? [closed]

Project Managers/Technical Leads sometimes tend to be over enthusiastic when it comes to software. But during code reviews if instead of functionality of the code the only complain one hears is about ...
6
votes
6answers
396 views

Need Help in Pointing to focus on the Key elements in Code Review Phase? [closed]

Please share your views on the code review process. If someone gave a code snippet and asked you to review that code, then what are the major things you will focus on that code Review process? For ...
6
votes
3answers
601 views

Why it is not recommended to have set-only property?

Today at work one of my colleague reviewed my code, and suggested me to remove set-only property and use method insted. As we both were busy with other stuffs, he told me to look at Property Design ...
21
votes
8answers
3k views

How should code reviews be Carried Out? [duplicate]

My previous question has to do with how to advance code reviews among the developers. Here I am interested in how a code review session should be carried out, so that both the reviewer and reviewed ...
18
votes
2answers
4k views

Recommended process for code reviews with mercurial

We typically used Perforce and SmartBear's Code Collaborator at Big Corp and now we're also going to be using Mercurial for certain projects. Code Collaborator support Mercurial (we are using ...
12
votes
7answers
1k views

What will be the best practice for having 'reviewed' source code in a source control repository?

What will be the best way to manage reviewed source code in a source control repository? Should the source code go through a review process before getting checked in, or should the code review happen ...