This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

19
votes
17answers
939 views

How to persuade programmers to follow the basic rules

There are several rules I must keep asking programmers to follow very often. They write code and, if it works, job is just done, for them. Most basic rules might be: Commiting changes Not writing ...
83
votes
16answers
6k views

Should I point out spelling/grammar related mistakes in someone's code?

While reviewing a coworker's code, I came across some spelling mistakes in function names and also grammatical errors like 'doesUserHasPermission()' instead of 'doesUserHavePermission()' in function ...
25
votes
5answers
779 views

Place to have my code reviewed by others [closed]

I am looking for a website where I can post code snippets and have them commented/reviewed by others. Does such a site exit?
3
votes
3answers
309 views

Python - Service, how to get a code review

I am usually a PHP and Delphi developer and have been getting into Python lately. I am developing an app and would love to get some feedback on the code, there are few things which I would love to ...
13
votes
6answers
503 views

Peer review for tests just like code reviews

Does anyone practice the "code review" process for functional tests? Do you find it useful? The way that my current employer practices SCRUM we include functional testing as part of our "must have ...
2
votes
1answer
443 views

How does your team approach technical code QA?

For the first time, our team is taking a rigorous approach to technical code QA. We identify work to QA by picking out top level classes and QA'ing it and everything it calls or uses below it (and ...
5
votes
8answers
685 views

How can I promote clean coding at my workplace?

I work with a lot of legacy Java and RPG code on an internal company application. As you might expect, a lot of the code is written in many different styles, and often is difficult to read because of ...
22
votes
17answers
1k views

Dealing with co-workers who do not have a consistent coding style?

What do you when you're working with someone who tends to write stylistically bad code? The code I'm talking about is usually technically correct, reasonably structured, and may even be ...
18
votes
3answers
887 views

Starting Up Code Review Process Where there Previously Was None?

Any tips for a group needing to start code reviews? We have no real software engineering processes currently. I have been working as software engineer for 7 years and have never seen any real ...
9
votes
4answers
520 views

Time allocated to code reviews

If you are doing code reviews How much time do you spend on code reviews, compared to implementation? How much of the changes undergo code review? you think it's to much / should be more? Are ...
20
votes
9answers
895 views

Tips on persuading boss that code review is a good thing

Let's say one works in a hypothetical company that has several developers that rarely worked together on projects and the Boss didn't believe that code reviews are worth the time and cost. What are ...
22
votes
4answers
513 views

Application / Code reviews for lone programmers?

Are there any services that 'for a reasonable price' will give and provide good and technical advice on applications. On a lot of projects, I'm usually the only developer, and sometimes, I think some ...
36
votes
16answers
4k views

Are code reviews necessary for junior developers?

I've worked at two companies, who each had a different methodology when it came to code reviews: In the first company, a code review was conducted by the team leaders and was required after the ...
4
votes
2answers
122 views

Project organization with professionals and students

I am working as a PhD student developing scientific/engineering simulations and algorithms to be tested in these simulations. These days the first student started to work on my project (for his ...
7
votes
3answers
3k views

What are great online code reviews tool for Open Source projects? [duplicate]

I would like to start new Open Source project, and I believe all check-ins should be reviewed before merged into trunk. What are some great online code review tools for Open Source projects that have ...
9
votes
4answers
306 views

Should I insist that we perform code reviews before merging back to trunk?

Requested re-post from StackOverflow: I'm working in a small development time with very limited time for development. We develop a tool that is important for the result of our work, but not used ...
46
votes
14answers
3k views

What's the most effective way to perform code reviews?

I've never found the ideal way to perform code reviews and yet often my customers require them. Each customer seems to do them in a different way and I've never felt satisfied in any of them. What ...
50
votes
17answers
2k views

Is a code review subjective or objective (quantifiable)?

I am putting together some guidelines for code reviews. We do not have one formal process yet and are trying to formalize it. And our team is geographically distributed. We are using TFS for source ...
120
votes
34answers
4k views

How do you make people accept code review? [duplicate]

All programmers have their style of programming. But some of the styles are let’s say... let’s not say. So you have code review to try to impose certain rules for good design and good programming ...
17
votes
2answers
554 views

Best way to relate code smells to a non technical audience? [closed]

I have been asked to present examples of code issues that were found during a code review. My audience is mostly non-technical and I want to try to express the issues in such a way that I convey the ...