This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

1
vote
1answer
208 views

Multistream Project v/s Single Stream project

If we want to have code reviews before a developer delivers his work, then can you suggest whether multi stream project { i.e., each developer create his own stream and view and later deliver to ...
1
vote
1answer
155 views

Suggestions for finding code to review, that is for CodeReview.SE

Looking for suggestions on finding code to review, or to be more clear, code on SE sites with excepted working code -- to suggest be posted to CodeReview.SE for optimization. The source of this ...
1
vote
1answer
58 views

How to avoid old commits/PRs that are painful to merge?

We have a pretty good code review process, but there are couple of issues. The most annoying problem is merging. From time to time the number of stuff to merge grows rapidly and some of the commits ...
1
vote
1answer
242 views

How to find duplicate strings

I allow my user to create profiles, meaning they potentially could create some with duplicate names. This can be problematic so I want to prevent them from doing so. I coded up this first pass ...
1
vote
2answers
176 views

How can I automate the process of code review

I have a team that works on multiple technologies. I want to know how can I automate the process of code review for .Net, .Net MVC, Python, PHP, Drupal and HTML5/CSS with JavaScript. I have read ...
1
vote
1answer
430 views

Checklist for coding MVVM web application [duplicate]

We are a small team working on a web application using MVVM design pattern using technologies like .NET, Knockout and HTML. I am trying to come up with a code review checklist for this, so that my ...
1
vote
0answers
64 views

Reject pull request or accept incorrect code? [duplicate]

Very often I have to review pull requests of fellow programmers and I face the problem - what should I do when the code is not as good as I would expect? Should I reject the pull request or ...
1
vote
0answers
121 views

Online Code Reviews [duplicate]

Possible Duplicate: Website for code review Where can I post my code online so people can comment, make suggestions, and/or criticism? I tried 4chan but people lose interest fast if you ...
0
votes
7answers
441 views

How do programmers deal with Project Lead/Managers? [closed]

Project Managers/Technical Leads sometimes tend to be over enthusiastic when it comes to software. But during code reviews if instead of functionality of the code the only complain one hears is about ...
0
votes
3answers
3k views

Logic inside class properties setters & getters [duplicate]

Trying to build a case against this as we have a developer that likes to use class properties in place of methods. I think it's a bad idea. In some cases he is accessing the data layer inside the ...
0
votes
2answers
258 views

Code Review tools - to use or not? [closed]

On my dev team, we're doing code reviews, however not in a proper way i believe. The issues our process suffers from: Not enough time is allocated for proper code review. Doing reviews is not ...
0
votes
1answer
101 views

How often to open pull requests [closed]

We are planning to use Git pull requests for code review in our company. Before we start I have a basic question: How often should I open a pull request? Is it best to open one for every little commit ...
0
votes
2answers
177 views

Revamp application [closed]

I am a software developer having an experience of 3 yrs. I want to play with latest technologies always. But this is not practical. Because say, I developed a web application in .Net 3.5, now its 30% ...
0
votes
1answer
84 views

How to get people to actually do code reviews promptly? [duplicate]

First things first, our company has decided to do code reviews. All of the engineers agree with (or accept) this. Code reviews are required as part of our development process for all commits. The ...
0
votes
1answer
113 views

Where to audit a codebase for dangerous code use [closed]

Not sure Programmers Stack Exchange is the place to ask this question, but thought I'd give it a go. Our team had a near miss recently with a nasty error where a method call had been added to the ...
0
votes
2answers
302 views

How do you evaluate a small piece of code? [closed]

I'm creating a website based on users' code, a place where they can share code in a social way and one of the features I'm currently developing is Code Review. This feature will allow users to ...
0
votes
1answer
89 views

How do I review code changes that are the result of syncing?

At my current job we develop code on a release branch and then do a code review. After all rework is done the final changes are also synced/merged to the 'main branch'. We want to be sure that all ...
0
votes
1answer
777 views

Diff annotation tool [closed]

Among the 11 proven practices for more effective, efficient peer code review, diff annotation seems to be the one particularly well suited to tool assistance. The article is written by the architect ...
0
votes
4answers
217 views

How to count condition coverage

I am wondering, What would be the correct condition coverage test cases for the following condition: if(A && E && (B || C || D)) Considering short circuiting, what cases would I ...
0
votes
1answer
76 views

How to keep class parameters visible while using generic argument passing

After writing some classes where class initialization requires multiple options, instead of writing several parameters into constructors or setters, I started passing an associative array of ...
0
votes
1answer
167 views

Understanding the solution of Exercise 1.12 of K&R's book as given in the book “The C Answer Book”

I am reading the solution of "The C Answer Book". I think that the solution of Ex. 1.12 can be shortened. The Exercise is as, Write a program that prints its input one word per line. The ...
-1
votes
2answers
113 views

Potential issues with code reviews [closed]

for clarity, code review = a team meeting and reviewing/sharing code What are the potentially negative aspects of the code review process in a development environment? What comes to mind for me ...
-1
votes
0answers
27 views

Is there a Code Review Tool that Integrates with Team Foundation Server [on hold]

Is there a code review software that integrates well with Team Foundation Server? It seems like there should be something that wouldn't even require me to take a diff, I could just provide my branch ...
-1
votes
0answers
51 views

Understanding the program that reads a set of text lines and prints the longest in K&R's book [migrated]

I'm reading K&R's book, section 1.9. The program for printing the longest line, from a given set of lines, is given as #include <stdio.h> #define MAXLINE 1000 /* maximum ...
-2
votes
2answers
136 views

Better control on code updates

I will briefly explain my situation. I have a website in PHP, this website is powered by a custom framework + some "plug-in" made ad hoc for it. I am the only developer of this. Until now I just ...
-4
votes
1answer
151 views

Code review revenge [closed]

In the company where I work we are doing code reviews. I gave some negative comments about the code (code duplication) of programmer A. My commit was OK and ready to merge and then programmer A added ...