This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

0
votes
4answers
203 views

How to count condition coverage

I am wondering, What would be the correct condition coverage test cases for the following condition: if(A && E && (B || C || D)) Considering short circuiting, what cases would I ...
-1
votes
2answers
103 views

Potential issues with code reviews [closed]

for clarity, code review = a team meeting and reviewing/sharing code What are the potentially negative aspects of the code review process in a development environment? What comes to mind for me ...
-1
votes
3answers
212 views

Programming task to test for focus on maintainability [closed]

I am looking for a programming task, which shows whether the coder has maintainability in mind while programming. I imagine giving a task to fix a bug in a method. It should be clear to the programmer ...
-1
votes
0answers
38 views

Basic PHP Factory Pattern code review [migrated]

I have an object, KbArticle, that originally in it's constructor, would try to return null if the SQL query that retrieves the data for its required properties came up with 0 rows. A friend told me ...
-2
votes
2answers
135 views

Better control on code updates

I will briefly explain my situation. I have a website in PHP, this website is powered by a custom framework + some "plug-in" made ad hoc for it. I am the only developer of this. Until now I just ...
-2
votes
0answers
32 views

Cashier function outputs difference results for three very specific cases [closed]

This is my first time posting here, so if the code is too long, I'll be more than happy to edit it. I'm making a cashier, a function that makes change. The odd thing is: If I buy 1.14 for 1.15, I ...