This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

learn more… | top users | synonyms (1)

1
vote
3answers
265 views

How to make code-review feel less like a way to *shift* the responsibility? [duplicate]

Sometimes it seems to me that people ask for code-reviews just so they would be able to say "Xyz reviewed my code!"(1) when something broke. Question, is that ever the case? (Or is it just my ...
1
vote
3answers
229 views

Is it appropriate to remove redundant code explicitly assigning the default values?

Sometimes while I'm editing something I see some useless code added by other developers, probably due to habit. Editing this code will not make any difference, so is it appropriate? In my specific ...
1
vote
4answers
443 views

How to avoid being overwhelmed when doing code review?

I'm pretty new to code review, and I feel often overwhelmed by incoming changes. I mean when there are serious code changes, coming from several developers I tend to accept everything without ...
1
vote
2answers
408 views

Is it good/safe OOP practice to have a method whose only purpose is to send/retrieve data from another class?

I have a class that performs basic MySQL operations. This is all in PHP. class dbTables { public $name; protected $fields = array(); // array of dbTableField objects public $result_sets = ...
1
vote
2answers
255 views

Why is there only code review?

In my team I have applied a culture of code review and feature review. The code might look great, written spectacularly, however the feature might not work. It seems to me as 2 different scopes ...
1
vote
1answer
133 views

Interface Design: Specific vs General parameter (A Minimal design vs anticipated use variation)

Code public interface IVehicle { string VehicleMake { get; } int MonthsSincePurchase { get; } bool IsApprovedUsed { get; } ... } public class WarrantyPopUpHandler { virtual bool ...
1
vote
4answers
173 views

What practical steps do you take to ensure you are thorough? [duplicate]

Bit of Context I'm not sure if this is fitting to the programmers.stackexchange area, but I'm not going to post it in SO. Any problem with ambiguity and I'll happily remove it. If I had to talk ...
1
vote
3answers
708 views

Should we enforce code style in our large codebase? [duplicate]

By "code style" I mean 2 things: Style, eg. // bad if(foo){ ... } // good if (foo) { ... } Conventions and idiomaticity, where two ways of writing the same thing are functionally equivalent, but ...
1
vote
4answers
334 views

Can I perform a code review although I am very inexperienced? [closed]

I have been teaching myself Python as a first language for 2 years now. So far I have done some online courses (NLP, Design of a Computer Program etc.) and solved some puzzles but never worked with ...
1
vote
3answers
408 views

Hacking Python “Requests” library.. How to start as an intermediate pythonista?

My question is conceptual, yet extremely vital for me. I'm an intermediate Python developer. I know fair enough about it, and actually use it on a daily basis. Now, I would like to transform my ...
1
vote
2answers
129 views

Apply filter only if not null

My function takes an optional parameter, type, which is used to filter through a collection. However, the filter should only apply if the parameter is passed in (in other words, non-null). If the ...
1
vote
1answer
140 views

Where to audit a codebase for dangerous code use [closed]

Not sure Programmers Stack Exchange is the place to ask this question, but thought I'd give it a go. Our team had a near miss recently with a nasty error where a method call had been added to the ...
1
vote
2answers
2k views

What are the things that you consider in reviewing an iOS source code? [closed]

We're going to do some peer reviews for our iOS projects. We're kind of inexperienced at reviewing each other's codes. The iOS developers attending the reviews will be from other projects, since ...
1
vote
1answer
115 views

Sorting Array before looping : best practice

I was going through JBAKE code at https://github.com/jbake-org/jbake/blob/master/src/main/java/org/jbake/app/Asset.java : 58 PFB the code. Why are we sorting the array here? if (assets != ...
1
vote
1answer
109 views

How do I review code changes that are the result of syncing?

At my current job we develop code on a release branch and then do a code review. After all rework is done the final changes are also synced/merged to the 'main branch'. We want to be sure that all ...
1
vote
2answers
669 views

Should the search engine return a dictionary or strongly typed objects?

I'm building a search engine using Lucene.NET / Solr.NET, and I'm wondering should search hits be returned as a dictionary or strongly typed object. public class SearchResult { public string ...
1
vote
3answers
239 views

How to integrate code reviews to a team [duplicate]

I work in a team that keeps growing. However, there are no code reviews and I see this as a problem every day. There are people with really limited skills committing code to our repository that I ...
1
vote
1answer
252 views

Multistream Project v/s Single Stream project

If we want to have code reviews before a developer delivers his work, then can you suggest whether multi stream project { i.e., each developer create his own stream and view and later deliver to ...
1
vote
1answer
161 views

Suggestions for finding code to review, that is for CodeReview.SE

Looking for suggestions on finding code to review, or to be more clear, code on SE sites with excepted working code -- to suggest be posted to CodeReview.SE for optimization. The source of this ...
1
vote
1answer
155 views

Interface Implementation: A parameter I don't need

Pseudo-Code interface IPagingInfo { int CurrentPageNo { get; } int RowsPerPage { get; } ... } interface ResultsRetriver { ResultRows GetResults(IPagingInfo pagingInfo); } class ...
1
vote
1answer
81 views

How to avoid old commits/PRs that are painful to merge?

We have a pretty good code review process, but there are couple of issues. The most annoying problem is merging. From time to time the number of stuff to merge grows rapidly and some of the commits ...
1
vote
1answer
650 views

How to find duplicate strings

I allow my user to create profiles, meaning they potentially could create some with duplicate names. This can be problematic so I want to prevent them from doing so. I coded up this first pass ...
1
vote
2answers
207 views

How can I automate the process of code review

I have a team that works on multiple technologies. I want to know how can I automate the process of code review for .Net, .Net MVC, Python, PHP, Drupal and HTML5/CSS with JavaScript. I have read ...
1
vote
1answer
557 views

Checklist for coding MVVM web application [duplicate]

We are a small team working on a web application using MVVM design pattern using technologies like .NET, Knockout and HTML. I am trying to come up with a code review checklist for this, so that my ...
1
vote
0answers
31 views

How can I test for performance issues in a specific piece of code? [duplicate]

I've inherited a problem from a programmer that isn't with our group anymore - a piece of our application suffers from performance issues under a particular set of circumstances. I can replicate ...
1
vote
0answers
100 views

How to approach code review with limited resources

I've been given the following task: A company is giving source code for its product (comprising over 1 million lines of C++, Java, with some assembly) for my review. The code will be loaded ...
1
vote
0answers
77 views

Reject pull request or accept incorrect code? [duplicate]

Very often I have to review pull requests of fellow programmers and I face the problem - what should I do when the code is not as good as I would expect? Should I reject the pull request or ...
1
vote
1answer
117 views

How to keep class parameters visible while using generic argument passing

After writing some classes where class initialization requires multiple options, instead of writing several parameters into constructors or setters, I started passing an associative array of ...
0
votes
7answers
448 views

How do programmers deal with Project Lead/Managers? [closed]

Project Managers/Technical Leads sometimes tend to be over enthusiastic when it comes to software. But during code reviews if instead of functionality of the code the only complain one hears is about ...
0
votes
2answers
319 views

Code Review tools - to use or not? [closed]

On my dev team, we're doing code reviews, however not in a proper way i believe. The issues our process suffers from: Not enough time is allocated for proper code review. Doing reviews is not ...
0
votes
1answer
290 views

How often to open pull requests [closed]

We are planning to use Git pull requests for code review in our company. Before we start I have a basic question: How often should I open a pull request? Is it best to open one for every little commit ...
0
votes
2answers
185 views

Revamp application [closed]

I am a software developer having an experience of 3 yrs. I want to play with latest technologies always. But this is not practical. Because say, I developed a web application in .Net 3.5, now its 30% ...
0
votes
3answers
244 views

How to count condition coverage

I am wondering, What would be the correct condition coverage test cases for the following condition: if(A && E && (B || C || D)) Considering short circuiting, what cases would I ...
0
votes
2answers
315 views

How do you evaluate a small piece of code? [closed]

I'm creating a website based on users' code, a place where they can share code in a social way and one of the features I'm currently developing is Code Review. This feature will allow users to ...
0
votes
1answer
920 views

Diff annotation tool [closed]

Among the 11 proven practices for more effective, efficient peer code review, diff annotation seems to be the one particularly well suited to tool assistance. The article is written by the architect ...
0
votes
1answer
102 views

Code Reviews: Working around the Github Pull Request limits [closed]

I'm currently working on a project where we introduced Github into our workflow. We started noticing that we get into the Github PR size limits pretty fast: This problem happens especially when we ...
0
votes
1answer
158 views

How long should a code review be? [closed]

Where I work, we are eight software developers and every task done must be reviewed by another developer. Often, I feel like the code reviews are done too quickly (example: a task completed in five ...
-1
votes
2answers
130 views

Potential issues with code reviews [closed]

for clarity, code review = a team meeting and reviewing/sharing code What are the potentially negative aspects of the code review process in a development environment? What comes to mind for me ...
-1
votes
1answer
167 views

eradicating the array = loop mindset [closed]

I have noticed a common issue in code reviews, that takes this form: // "arr" is an array for (i = 0; i < arr.length; ++i) { if (i == 3) { // do something with arr[i] } if (i ...
-1
votes
1answer
107 views

How to get people to actually do code reviews promptly? [duplicate]

First things first, our company has decided to do code reviews. All of the engineers agree with (or accept) this. Code reviews are required as part of our development process for all commits. The ...
-1
votes
0answers
17 views

Standalone tool for code review that outputs a document of common format [on hold]

I'm looking for a tool (online or desktop) that I can paste code into, add some comments inline and send the end result to my team. The end result may be an image or html page, or pdf of the code with ...
-2
votes
2answers
137 views

Better control on code updates

I will briefly explain my situation. I have a website in PHP, this website is powered by a custom framework + some "plug-in" made ad hoc for it. I am the only developer of this. Until now I just ...
-2
votes
1answer
195 views

Searching for 2 numbers that equal 10 [closed]

During an interview today I was asked to write a function that accepted an array of integers and return the positions of two values in the array that the sum was 10. My code was C# public string ...