Tag Info

New answers tagged

1

[This answer is a little broader than the question originally posed, since this is the redirect for so many other questions on code reviews.] Here are some principles I find useful: Criticize privately, praise publicly. Let someone know about a bug in their code one-on-one. If they did something brilliant or took on a task nobody wanted, praise them at ...


0

Service [...] needs to be fetched the way shown in the sample. Then why would you get it via parameter in the first place? This opens the door to pass the Service in some other undesirable way and if that's not possible, the parameter is quite useless anyway. Removing the parameter seems to be a good idea. doMoreWork() is not just about calling ...


0

This answer is based on two assumptions. First, you are using a static analysis tool that is more than a style checker (PMD and/or FindBugs instead of Checkstyle, for example). Second, the tool has been properly configured with regards to the errors detected and the severity of the error for the given process or product. Yes, static analysis tools that are ...


5

The tools you list have nothing to do with code reviews. They are there exactly to let the reviewers to focus on more useful subjects. Code reviews are for important things which cannot be automated: using a design pattern when another one matches better, over-documenting clear code or under-documenting unclear one, not using language features which can ...



Top 50 recent answers are included