27,041 reputation
25496
bio website thehungersite.com
location United Kingdom
age 46
visits member for 4 years, 1 month
seen 11 hours ago
experienced software engineer with many years in the industry, mostly c++ for large-scale, high-reliability systems.

Jan
31
comment What tools can be used to facilitate code reviews after commits?
Reviewboard was a bit of a pain in the early days - the unified diff you need to generate is actually very easy to do in SVN though TortoiseSVN does it all the time!). Uploading the diff to reviewboard was the problem for me - but I was running it on Windows.
Jan
30
comment Are classes with only a single method a problem?
@DocBrown class over namespace... so would I. But, if anyone asks "what should I do" I have to tell them to think about what OO is fundamentally about to avoid letting the 'easy option' become a bad habit. Any static class functions is really an anti-pattern IMHO, but I don't think we have many practical alternatives sometimes. Got some interesting discussion going for such a simple question though, cheers!
Jan
30
comment Why should passwords be encrypted if they are being stored in a secure database?
is 5.3.3 to 5.3.8 much of an upgrade?
Jan
30
revised Are classes with only a single method a problem?
added 1516 characters in body
Jan
30
comment Are classes with only a single method a problem?
@DocBrown I read it more as a "does proper OO design mean we should create functional classes" - for beginners, I would advocate not making classes that are just collections of functions (obviously in the real world such things are ok once you know why you'd make such things)(because you end up with the "better C" design pattern then). The OP does say he instantiates these classes just to call the function, and that's not "proper" OO design. Some languages would prefer namespace or modules, some would prefer a static class. These are practical ways to mange the code, but are not OO.
Jan
29
comment Are classes with only a single method a problem?
@DocBrown who's to say there are any other methods, he says 1 public method, but that's all there could be. Still, I think data-driven OO design is the way OO should be done.
Jan
29
comment Are classes with only a single method a problem?
ah but beginners OO where 1 function gets turned into a class isn't really OO at all, and only encourages the massive decoupling that ends up in a thousand files of classes no-one can maintain. I think its best to think of a class as a "data-wrapper" not a "functionality wrapper", that'll give a beginner a better understanding of how to think about OO programs.
Jan
29
answered Are classes with only a single method a problem?
Jan
28
answered Is this how dynamic language copes with dynamic requirement?
Jan
27
answered A programmer as project manager or non-programmer?
Jan
27
answered How do you get developers to want to write good code they can be proud of?
Jan
24
comment Too many technologies … too little time to learn them all
the more you learn, the more you realise just how little you know.
Jan
24
answered Is it a good idea to collect anonymous usage statistics in a free program?
Jan
23
comment How to do structured code reviews
@Nicolai my pleasure. now, we just have to get you off TFS and onto something really good :-)
Jan
21
awarded  Good Answer
Jan
20
comment Is virtual machine image a good protection for source code?
@MichaelT Google will sell you a physical server preconfigured with their mapping service on it. Companies install those and we know Google steals your data :)
Jan
20
answered Security concern regarding web service
Jan
17
comment How to do structured code reviews
@Nicolai the reason is that only reviewed code gets merged onto a more senior branch. So the dev can make as many mistakes as he likes and it won't affect your version history - in the release branch. It also means he can code many different tasks on his branch whilst waiting for reviews - when each passes review, only those revisions get merged across. Working in main just means you have a lot more work to do managing which revisions go with which task, and they will get mixed up together.
Jan
17
revised How to do structured code reviews
added 689 characters in body
Jan
17
comment How to do structured code reviews
Even with private (or feature branches) its ok to review post-commit. After all, the worst that can happen is that you have multiple commits for a particular task (which is how many people work anyway). Ok, you might be tempted to ignore the reviews.. but that's an entirely different kind of problem. (oh, and a huge benefit of a post-commit review are the diffs that the SCM gives you - without any cheating being possible)