369 reputation
27
bio website
location
age 28
visits member for 3 years, 5 months
seen May 19 at 23:09

May
3
awarded  Student
Oct
15
awarded  Yearling
Aug
5
awarded  Nice Answer
Jul
19
awarded  Critic
Oct
14
awarded  Necromancer
Jul
29
answered Is it reasonable to NOT provide technical documentation and unit tests to client?
Jul
29
answered What information should a good (method- / class-) comment contain?
Jul
29
awarded  Supporter
Jul
29
answered Best practices for connecting from ASP.NET to SQL Server?
Jul
29
awarded  Editor
Jul
29
revised Recommended process for code reviews with mercurial
Clarified sentence about pushing code
Jul
25
awarded  Revival
Jul
24
awarded  Teacher
Apr
27
comment Recommended process for code reviews with mercurial
It probably wasn't clear from the answer, but it doesn't actually make it into the repository unless all of the changes have been added to the code review and the review is complete. If the hook exits with a non-zero exit code, Mercurial rolls back all of the changes that were being pushed. Thus, that particular hook provides a very convenient place to not only get the diffs for the review, but also to enforce the review before the changes are allowed into the repository.
Apr
25
answered Recommended process for code reviews with mercurial