Reputation
Next privilege 125 Rep.
Vote down
Badges
2
Impact
0 people reached

  • 0 posts edited
  • 4 helpful flags
  • 9 votes cast
Sep
11
comment What is the purpose of a Code Review
@Pimgd: In addition, when following SOLID I would imagine to many if statements could possibly mean a class has to many responsibilities and/or abstraction might be needed to deal with that. Though I'm not sure if that logic applies across all languages evenly or to some at all.
Sep
11
comment What is the purpose of a Code Review
We do code reviews in our JavaScript code, mainly to ensure the developers stick to the outlined standards, using the set out pattern when designing modules, using the components provided and not start doing ninja coding (intentionally or not) around problems we already have solutions for. They also are great to spot someone accidentally over-writing this context, not using .hasOwnProperty in places it should be in, etc, etc. -- So, mainly for standards. In a managed language like C# you off course have several less reasons then for dynamic languages.
Jul
1
comment Should I use different projects for building different layers in a 3-layer model?
Why separate Business Logic from the Business Entities? You can add the logic to the entity directly to prevent anyone from circumventing the logic. For example a SubscriberList entity can have a AddSubscriber(Person person) method which can now make sure a person can only be added as a subscriber if Person.Age >= 18. If you have the logic outside the entity you cannot guarantee that the rules is always enforced.
May
2
awarded  Autobiographer
Aug
13
comment Don't Use “Static” in C#?
Yes, you are right, if an existing culture in an existing project exists it would be more damaging than helping to change the way things are done.
Aug
13
comment Don't Use “Static” in C#?
If a class is made static for the right reasons and correctly implemented such as for example extension methods they are still testable very much as they would have no external dependencies and are self-contained and as such should not require mocking. Should the need for an interface not be driven by the design requirement to best full-fill a business requirement not for the sake of keeping a pure IoC/DI project?
Aug
13
comment Don't Use “Static” in C#?
Why would he write tests for 3rd party libraries? Don't you usualy just test your own code assuming the creators of the 3rd party library have done their testing?
Aug
13
comment Don't Use “Static” in C#?
+1 for mentioning that the statement was to general and mentioning extension methods, which also can be tested and dependencies can still be mocked as far as I know.
Apr
29
awarded  Supporter