183 reputation
8
bio website ustimen.co
location Novosibirsk, Russia
age 31
visits member for 3 years
seen Mar 20 at 9:03

Web-developer


Feb
26
awarded  Caucus
Jan
13
awarded  Autobiographer
Oct
16
comment Is a code review which uses only code comments a good idea?
@JohannesS. which vcs do you using? Also do you have some ready howto or wiki about their integration? Nice to have such one.
Oct
7
awarded  Scholar
Oct
7
accepted Is a code review which uses only code comments a good idea?
Oct
5
comment Is a code review which uses only code comments a good idea?
@AndrewFinnell, this form, and forms like this is that's why I dont' like complex solutions :( my.atlassian.com/ondemand/signup/jira,fisheye And there are just no crucible! :) $('.submit-form input').length == 58
Oct
5
comment Is a code review which uses only code comments a good idea?
@AndrewFinnell, ... doesn't "$10/MO" means that it's 10$ per month? Or I looking for in wrong place?
Oct
5
comment Is a code review which uses only code comments a good idea?
"gerrit" I installed it -- it wasnt so hard. I just fail to use it! And also it has ugly UI and workflow.
Oct
5
comment Is a code review which uses only code comments a good idea?
wow! We need to try it instead of our lovely redmine.
Oct
5
comment Is a code review which uses only code comments a good idea?
@AndrewFinnell, it's $10 per month :) atlassian.com/software/crucible/pricing But main bad thing is that it can have dependency on jira.
Oct
4
comment Is a code review which uses only code comments a good idea?
@KonradRudolph, by minizing I means to minize interactions, that break developer`s concentration. For example: do you like, when you do some complex thing and someone asks you about not-so-critical now? After you need to "reboot" yuorself into complex task again. I dont' mean we should work as in jail here :)
Oct
4
comment Is a code review which uses only code comments a good idea?
"keeping a record" -- only when we not squashing review commits ... But then we meet with a "review-chat" in version control system... Those who likes squashing and "clean history" will not be very glad.
Oct
4
comment Is a code review which uses only code comments a good idea?
"person can ... delete the comment" -- it's an issue. +1
Oct
4
comment Is a code review which uses only code comments a good idea?
"interactivity" -- author can answer in another comments, below initial. Just like in wikipedia style.
Oct
4
comment Is a code review which uses only code comments a good idea?
"place for praise" -- also possible, but after squashing will be lost :( I already see one issue -- we lost review history when squashing commits.
Oct
4
comment Is a code review which uses only code comments a good idea?
"compactness" -- I think it could be done by one comment like "// REV Dude, we have 37 places where pointers were not checked first, including this one. Please RTFM"
Oct
4
comment Is a code review which uses only code comments a good idea?
then we need some good code-review tool. Our current described approach is mostly political as people should invent some ethiquet and follow it.
Oct
4
awarded  Commentator
Oct
4
comment Is a code review which uses only code comments a good idea?
@KonradRudolph, we should minimize the interaction and interact only when it really needs. Same as in "normal" code review tools: reviewee doesn't need to be in "chat" with reviewer in same time frame. Insted we can do another features and answer in convonient time.
Oct
4
comment Is a code review which uses only code comments a good idea?
@DocBrown, "face-to-face" is much better. But face-to-face is not good, when we need to give reviewee "isolation" to work on another feauture. Something like why emails are better than phonecalls -- you can manage your time and concentrate better.