2,077 reputation
71939
bio website
location
age 32
visits member for 3 years, 10 months
seen 5 hours ago

A software developer.


Feb
18
awarded  Nice Question
Feb
18
comment How should code reviews be Carried Out?
I seriously can't imagine how you can do Formal Code Review as described above in a consistent, scalable manner. You may be able to do it sporadically, when you feel like it, or you may be able to do it if your team is small and write very few code, but you definitely can't do it if you are under tight deadline or if your team is consisting of 5 developers and above. I think.
Feb
18
comment How should code reviews be Carried Out?
@Tim, so that means that the reviewers are alerted every time a check-in is committed. But isn't it a bit too taxing for the reviewers, especially if they need to write their own code?
Feb
18
comment How should code reviews be Carried Out?
@Tim, some of the points which I would like to know is: 1. how the reviewer does the review? Does he go through line by line of the changes? How often he does the pull? If too often, he would be spending all the time reviewing, if too infrequent, the changes get piled up and nobody likes a marathon review session. Did he review for big architecture changes ( like "you should create base class and then subclass rather than copy and paste")?
Feb
18
comment How should code reviews be Carried Out?
@jmquigley, yup, daily build. I'm even thinking about doing continuous build in the future. But currently no need.
Feb
18
comment How should code reviews be Carried Out?
@Tim, may I know what source control you are using? Also, after the description about after the pull how the review takes place is a bit vague, mind to elaborate?
Feb
18
comment How should code reviews be Carried Out?
@jmquigley, do you do daily builds? In our setting we have daily builds and if I follow your strategy, I have to personally approve all the changes on every single day, probably before the build starts, that's a bit too taxing for me, I guess?
Feb
18
asked Interop Best Practices: Should I use Static Class, or Normal Classes
Feb
18
revised How should code reviews be Carried Out?
added 199 characters in body
Feb
18
comment How should code reviews be Carried Out?
@jmpquigley, mind to share on how frequently you do your code review? As soon as the code is check in? Once a week? Do you allocate a fix time in every week to do this?
Feb
18
revised How should code reviews be Carried Out?
added 1 characters in body
Feb
18
asked How should code reviews be Carried Out?
Feb
17
revised Developer Compensation System
added 113 characters in body
Feb
17
revised Developer Compensation System
added 137 characters in body
Feb
17
comment Developer Compensation System
@ChrisF, I've reworded the question, not sure whether it really improves.
Feb
17
revised Developer Compensation System
deleted 161 characters in body
Feb
17
revised Developer Compensation System
added 97 characters in body
Feb
17
comment Is software innovation still primarily North American and European? Why, and for how much longer?
I'm a Chinese and I agree with you on that.
Feb
17
revised Developer Compensation System
added 122 characters in body
Feb
17
asked Developer Compensation System